Messages in this thread | | | Date | Wed, 4 Aug 2021 17:27:24 +0200 | From | Jan Kara <> | Subject | Re: [PATCH V3 3/5] ext4: remove the repeated comment of ext4_trim_all_free |
| |
On Sat 24-07-21 15:41:22, Wang Jianchao wrote: > From: Wang Jianchao <wangjianchao@kuaishou.com> > > Reviewed-by: Andreas Dilger <adilger@dilger.ca> > Signed-off-by: Wang Jianchao <wangjianchao@kuaishou.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > fs/ext4/mballoc.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index e3844152a643..34be2f07449d 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -6274,15 +6274,10 @@ static int ext4_try_to_trim_range(struct super_block *sb, > * @max: last group block to examine > * @minblocks: minimum extent block count > * > - * ext4_trim_all_free walks through group's buddy bitmap searching for free > - * extents. When the free block is found, ext4_trim_extent is called to TRIM > - * the extent. > - * > - * > * ext4_trim_all_free walks through group's block bitmap searching for free > * extents. When the free extent is found, mark it as used in group buddy > * bitmap. Then issue a TRIM command on this extent and free the extent in > - * the group buddy bitmap. This is done until whole group is scanned. > + * the group buddy bitmap. > */ > static ext4_grpblk_t > ext4_trim_all_free(struct super_block *sb, ext4_group_t group, > -- > 2.17.1 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |