Messages in this thread | | | Date | Wed, 4 Aug 2021 17:46:25 +0200 | From | Jan Kara <> | Subject | Re: [PATCH V3 5/5] ext4: make fallocate retry when err is ENOSPC |
| |
On Wed 04-08-21 17:32:21, Jan Kara wrote: > On Sat 24-07-21 15:41:24, Wang Jianchao wrote: > > From: Wang Jianchao <wangjianchao@kuaishou.com> > > > > The blocks may be waiting for journal commit to be freed back to > > mb buddy. Let fallocate wait and retry in that case. > > > > Signed-off-by: Wang Jianchao <wangjianchao@kuaishou.com> > > Did you really observe this? Because the retry is already handled in > ext4_alloc_file_blocks() that's used by ext4_fallocate(). So no retry > should be needed there.
Oh, I can see you've addressed these already in another reply. I'll comment there.
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |