Messages in this thread | | | Date | Tue, 31 Aug 2021 10:30:25 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2 03/13] kbuild: store the objtool command in *.cmd files |
| |
On Tue, Aug 31, 2021 at 04:39:54PM +0900, Masahiro Yamada wrote: > objtool_dep includes include/config/{ORC_UNWINDER,STACK_VALIDATION} > so that all the objects are rebuilt when any of CONFIG_ORC_UNWINDER > and CONFIG_STACK_VALIDATION is toggled. > > As you can see in 'objtool_args', there are more CONFIG options > that affect the objtool command line. > > Adding more and more include/config/* is ugly and unmaintainable. > > Another issue is that non-standard objects are needlessly rebuilt. > Objects specified as OBJECT_FILES_NON_STANDARD is not processed by > objtool, but they are rebuilt anyway when CONFIG_ORC_UNWINDER or > CONFIG_STACK_VALIDATION is toggled. This is not a big deal, but > better to fix. > > A cleaner and more precise fix is to include the objtool command in > *.cmd files so any command change is naturally detected by if_change. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Yeah, nice solution for this.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |