Messages in this thread | | | From | Masahiro Yamada <> | Date | Fri, 3 Sep 2021 08:42:39 +0900 | Subject | Re: [PATCH v2 05/13] kbuild: detect objtool update without using .SECONDEXPANSION |
| |
On Wed, Sep 1, 2021 at 2:33 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Tue, Aug 31, 2021 at 12:40 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > Redo commit 8852c5524029 ("kbuild: Fix objtool dependency for > > 'OBJECT_FILES_NON_STANDARD_<obj> := n'") to add the objtool > > dependency in a cleaner way. > > > > Using .SECONDEXPANSION ends up with unreadable code due to escaped > > dollars. Also, it is not efficient because the second half of > > Makefile.build is parsed twice every time. > > > > Append the objtool dependency to the *.cmd files at the build time. > > > > This is what fixdep and gen_ksymdeps.sh already do. So, following the > > same pattern seems a natural solution. > > > > This allows us to drop $$(objtool_deps) entirely. > > s/objtool_deps/objtool_dep/ > > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > You and Josh should be cc'ing each other explicitly on these kind of changes. >
FWIW, this is the entire patch set if Josh is interested:
https://patchwork.kernel.org/project/linux-kbuild/list/?series=539621
-- Best Regards Masahiro Yamada
| |