Messages in this thread | | | Date | Fri, 27 Aug 2021 11:45:56 +1200 | From | Luke Jones <> | Subject | Re: [PATCH v5 0/1] asus-wmi: Add support for custom fan curves |
| |
On Fri, Aug 27 2021 at 11:42:58 +1200, Luke D. Jones <luke@ljones.dev> wrote: > Add support for custom fan curves found on some ASUS ROG laptops. > > The patch has gone through a few revisions as others tested it and > requested bahaviour changes or reported issues. V4 should be > considered > finalised for now and I won't submit a new version until V4 has been > reviewed.
Sorry, I copy/pasted my last log. This V5 is pretty much finalised now. Testing and self-review seems to have caught everything it possibly can.
Cheers, Luke.
> - V1 > + Initial patch work > - V2 > + Don't fail and remove wmi driver if error from > asus_wmi_evaluate_method_buf() if error is -ENODEV > - V3 > + Store the "default" fan curves > + Call throttle_thermal_policy_write() if a curve is erased to > ensure > that the factory default for a profile is applied again > - V4 > + Do not apply default curves by default. Testers have found that > the > default curves don't quite match actual no-curve behaviours > + Add method to enable/disable curves for each profile > - V5 > + Remove an unrequired function left over from previous iterations > + Ensure default curves are applied if user writes " " to a curve > path > + Rename "active_fan_curve_profiles" to > "enabled_fan_curve_profiles" to > better reflect the behavious of this setting > + Move throttle_thermal_policy_write_*pu_curves() and rename to > fan_curve_*pu_write() > + Merge fan_curve_check_valid() and fan_curve_write() > + Remove some leftover debug statements > + Remove '\n' causing double-up of '\n\n' > > Luke D. Jones (1): > asus-wmi: Add support for custom fan curves > > drivers/platform/x86/asus-wmi.c | 618 > ++++++++++++++++++++- > include/linux/platform_data/x86/asus-wmi.h | 2 + > 2 files changed, 619 insertions(+), 1 deletion(-) > > -- > 2.31.1 >
| |