Messages in this thread | | | Subject | Re: [PATCH 06/10] staging: r8188eu: clean up the usb_readXY functions | From | Michael Straube <> | Date | Sun, 22 Aug 2021 14:25:10 +0200 |
| |
On 8/21/21 6:48 PM, Martin Kaiser wrote: > Remove unnecessary variables, summarize declarations and assignments. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > --- > drivers/staging/r8188eu/hal/usb_ops_linux.c | 30 +++++---------------- > 1 file changed, 7 insertions(+), 23 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c > index dccb9fd34777..cb969a200681 100644 > --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c > +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c > @@ -98,46 +98,30 @@ static int usbctrl_vendorreq(struct intf_hdl *pintfhdl, u16 value, void *pdata, > > static u8 usb_read8(struct intf_hdl *pintfhdl, u32 addr) > { > - u16 wvalue; > - u16 len; > - u8 data = 0; > - > - > - > - wvalue = (u16)(addr & 0x0000ffff); > - len = 1; > - > - usbctrl_vendorreq(pintfhdl, wvalue, &data, len, REALTEK_USB_VENQT_READ); > - > + u16 wvalue = (u16)(addr & 0x0000ffff); > + u8 data; > > + usbctrl_vendorreq(pintfhdl, wvalue, &data, 1, REALTEK_USB_VENQT_READ); > > return data; > - > } > > static u16 usb_read16(struct intf_hdl *pintfhdl, u32 addr) > { > - u16 wvalue; > - u16 len; > + u16 wvalue = (u16)(addr & 0x0000ffff); > __le32 data; > > - wvalue = (u16)(addr & 0x0000ffff); > - len = 2; > - usbctrl_vendorreq(pintfhdl, wvalue, &data, len, REALTEK_USB_VENQT_READ); > + usbctrl_vendorreq(pintfhdl, wvalue, &data, 2, REALTEK_USB_VENQT_READ); > > return (u16)(le32_to_cpu(data) & 0xffff); > } > > static u32 usb_read32(struct intf_hdl *pintfhdl, u32 addr) > { > - u16 wvalue; > - u16 len; > + u16 wvalue = (u16)(addr & 0x0000ffff); > __le32 data; > > - wvalue = (u16)(addr & 0x0000ffff); > - len = 4; > - > - usbctrl_vendorreq(pintfhdl, wvalue, &data, len, REALTEK_USB_VENQT_READ); > + usbctrl_vendorreq(pintfhdl, wvalue, &data, 4, REALTEK_USB_VENQT_READ); > > return le32_to_cpu(data); > } >
Looks good to me.
Acked-by: Michael Straube <straube.linux@gmail.com>
Thanks, Michael
| |