Messages in this thread | | | Subject | Re: [PATCH 04/10] staging: r8188eu: rewrite usb vendor request defines | From | Michael Straube <> | Date | Sun, 22 Aug 2021 14:18:22 +0200 |
| |
On 8/21/21 6:48 PM, Martin Kaiser wrote: > Replace the numeric values with USB constants to make their > meaning clearer. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > --- > drivers/staging/r8188eu/include/usb_ops.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/include/usb_ops.h b/drivers/staging/r8188eu/include/usb_ops.h > index 5d290199e37c..b6a1cd536adf 100644 > --- a/drivers/staging/r8188eu/include/usb_ops.h > +++ b/drivers/staging/r8188eu/include/usb_ops.h > @@ -8,8 +8,8 @@ > #include "drv_types.h" > #include "osdep_intf.h" > > -#define REALTEK_USB_VENQT_READ 0xC0 > -#define REALTEK_USB_VENQT_WRITE 0x40 > +#define REALTEK_USB_VENQT_READ (USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE) > +#define REALTEK_USB_VENQT_WRITE (USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE) > #define REALTEK_USB_VENQT_CMD_REQ 0x05 > #define REALTEK_USB_VENQT_CMD_IDX 0x00 > >
Looks good to me.
Acked-by: Michael Straube <straube.linux@gmail.com>
Thanks, Michael
| |