Messages in this thread Patch in this message | | | From | Brad Larson <> | Date | Sun, 22 Aug 2021 18:57:29 -0700 | Subject | Re: [PATCH v2 10/13] dt-bindings: spi: cadence-qspi: Add support for Pensando Elba SoC |
| |
Hi Pratyush,
On Tue, Mar 30, 2021 at 4:12 AM Pratyush Yadav <p.yadav@ti.com> wrote: > > Hi Brad, > > On 28/03/21 06:59PM, Brad Larson wrote: > > Add new vendor Pensando Systems Elba SoC compatible > > string and convert to json-schema. > > > > Signed-off-by: Brad Larson <brad@pensando.io> > > --- > > .../bindings/spi/cadence-quadspi.txt | 68 -------- > > .../bindings/spi/cadence-quadspi.yaml | 153 ++++++++++++++++++ (...) > > +properties: > > + compatible: > > + contains: > > + enum: > > + - cdns,qspi-nor # Generic default > > + - ti,k2g-qspi # TI 66AK2G SoC > > + - ti,am654-ospi # TI AM654 SoC > > + - intel,lgm-qspi # Intel LGM SoC > > + - pensando,cdns-qspi # Pensando Elba SoC > > Wouldn't this allow any combination of all 5 strings? So for example > this would allow "ti,am654-ospi", "pensando,cdns-qspi" which is > obviously not correct. > > I sent a patch recently [0] that does this correctly and it has gotten > Rob's blessing. So I suggest you build your patch on top of that.
Thanks for the pointer to the patch that creates yaml binding spi/cdns,qspi-nor.yaml. All I will need to do now for the updated patchset is this
--- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml @@ -20,6 +20,7 @@ properties: - ti,k2g-qspi - ti,am654-ospi - intel,lgm-qspi + - pensando,elba-qspi - const: cdns,qspi-nor - const: cdns,qspi-nor
Regards, Brad
| |