Messages in this thread | | | From | Brad Larson <> | Date | Sun, 22 Aug 2021 18:07:48 -0700 | Subject | Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control |
| |
Hi Krzysztof,
On Fri, Mar 5, 2021 at 3:25 AM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > On 04/03/2021 04:41, Brad Larson wrote: > > This GPIO driver is for the Pensando Elba SoC which > > provides control of four chip selects on two SPI busses. [...] > > + ret = devm_gpiochip_add_data(&pdev->dev, &p->chip, p); > > + if (ret) { > > + dev_err(&pdev->dev, "unable to add gpio chip\n"); > > + return ret; > > + } > > + > > + dev_info(&pdev->dev, "elba spics registered\n"); > > Don't print trivial probe results, unless you print here something > useful. If you need it for debugging, keep it dev_dbg.
Removed that extraneous logging
Regards, Brad
| |