Messages in this thread | | | From | "Sa, Nuno" <> | Subject | RE: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume() | Date | Fri, 20 Aug 2021 06:46:59 +0000 |
| |
> From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Thursday, August 19, 2021 7:21 PM > To: Yang Yingliang <yangyingliang@huawei.com> > Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; > prabhakar.mahadev-lad.rj@bp.renesas.com; jic23@kernel.org > Subject: Re: [PATCH -next] iio: adc: add missing > clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume() > > On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang > <yangyingliang@huawei.com> wrote: > > > > Add clk_disable_unprepare() on error path in > rzg2l_adc_pm_runtime_resume(). > > ... > > > ret = clk_prepare_enable(adc->adclk); > > - if (ret) > > + if (ret) { > > + clk_disable_unprepare(adc->pclk); > > return ret; > > + } > > Huh?! >
Had the same reaction when looked at this patch. Look at the clock names :).
- Nuno Sá
| |