lkml.org 
[lkml]   [2021]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()
From
Date
Hi,

On 2021/8/20 1:20, Andy Shevchenko wrote:
> On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
>> Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume().
> ...
>
>> ret = clk_prepare_enable(adc->adclk);
>> - if (ret)
>> + if (ret) {
>> + clk_disable_unprepare(adc->pclk);
>> return ret;
>> + }
> Huh?!
The pclk need be disabled, when enable adclk failed.
      ^                                                         ^^
>

\
 
 \ /
  Last update: 2021-08-20 03:53    [W:0.072 / U:1.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site