Messages in this thread Patch in this message | | | From | CGEL <> | Subject | [PATCH linux-next] x86:iormap: replace a printk + WARN_ON_ONCE() to a WARN_ONCE() Replace a printk+WARN_ON() by a WARN(); this increases the chance of the string making it into the bugreport. | Date | Thu, 19 Aug 2021 23:04:08 -0700 |
| |
From: jing yangyang <jing.yangyang@zte.com.cn>
This issue was detected with the help of Coccinelle.
Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn> --- arch/x86/mm/ioremap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c index 60ade7d..f2ded4a 100644 --- a/arch/x86/mm/ioremap.c +++ b/arch/x86/mm/ioremap.c @@ -195,9 +195,8 @@ static void __ioremap_check_mem(resource_size_t addr, unsigned long size, return NULL; if (!phys_addr_valid(phys_addr)) { - printk(KERN_WARNING "ioremap: invalid physical address %llx\n", + WARN_ONCE(1, "ioremap: invalid physical address %llx\n", (unsigned long long)phys_addr); - WARN_ON_ONCE(1); return NULL; } -- 1.8.3.1
| |