Messages in this thread | | | From | "Fabio M. De Francesco" <> | Subject | Re: [PATCH] staging: r8188eu: remove forward declaration of Efuse_Read1ByteFromFakeContent | Date | Sat, 21 Aug 2021 05:17:06 +0200 |
| |
On Saturday, August 21, 2021 2:05:08 AM CEST Phillip Potter wrote: > Remove forward declaration of Efuse_Read1ByteFromFakeContent function > from core/rtw_efuse.c, as the function is defined in full directly > after this and therefore this forward declaration is redundant. > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > --- > drivers/staging/r8188eu/core/rtw_efuse.c | 6 ------ > 1 file changed, 6 deletions(-)
Philip,
It's pretty clear that this function has only a translation unit visibility. Why don't you make it clear by defining it with storage class "static"?
Thanks,
Fabio
| |