lkml.org 
[lkml]   [2021]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: r8188eu: remove forward declaration of Efuse_Read1ByteFromFakeContent
From
Date


On 8/21/21 5:17 AM, Fabio M. De Francesco wrote:
> On Saturday, August 21, 2021 2:05:08 AM CEST Phillip Potter wrote:
>> Remove forward declaration of Efuse_Read1ByteFromFakeContent function
>> from core/rtw_efuse.c, as the function is defined in full directly
>> after this and therefore this forward declaration is redundant.
>>
>> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
>> ---
>> drivers/staging/r8188eu/core/rtw_efuse.c | 6 ------
>> 1 file changed, 6 deletions(-)
>
> Philip,
>
> It's pretty clear that this function has only a translation unit visibility.
> Why don't you make it clear by defining it with storage class "static"?
>
> Thanks,
>
> Fabio
>
>

Hi Phillip,

I agree with Fabio, making the function static avoids the
[-Wmissing-prototypes] warning and makes it clear that it is only used
in this file.

Thanks,

Michael

\
 
 \ /
  Last update: 2021-08-21 10:32    [W:0.044 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site