lkml.org 
[lkml]   [2021]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] KVM: SEV: improve the code readability for ASID management
Hi Paolo,

Thanks. I think Sean's suggestion makes sense. I will update it with
that one and remove the 'fixes' line.

Regards
-Mingwei

On Mon, Aug 2, 2021 at 9:53 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 02/08/21 18:17, Sean Christopherson wrote:
> >
> > Rather than adjusting the bitmap index, what about simply umping the bitmap size?
> > IIRC, current CPUs have 512 ASIDs, counting ASID 0, i.e. bumping the size won't
> > consume any additional memory. And if it does, the cost is 8 bytes...
> >
> > It'd be a bigger refactoring, but it should completely eliminate the mod-by-1
> > shenanigans, e.g. a partial patch could look like
>
> This is also okay by me if Mingwei agrees, of course. I have already
> queued his patch, but I can replace it with one using a nr_asids-sized
> bitmap too.
>
> Paolo
>

\
 
 \ /
  Last update: 2021-08-02 19:26    [W:0.065 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site