lkml.org 
[lkml]   [2021]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 06/20] platform/x86: intel_scu: Move to intel sub-directory
On Thu, Aug 19, 2021 at 6:33 AM Kate Hsuan <hpa@redhat.com> wrote:
>
> Move intel_scu to intel sub-directory to improve readability.

Intel SCU

...

> -obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o
> -obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o
> -obj-$(CONFIG_INTEL_SCU_PLATFORM) += intel_scu_pltdrv.o
> -obj-$(CONFIG_INTEL_SCU_WDT) += intel_scu_wdt.o
> -obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += intel_scu_ipcutil.o

> +

Stray change?

...

> +obj-$(CONFIG_INTEL_SCU_IPC) += scu/
> +obj-$(CONFIG_INTEL_SCU_PCI) += scu/
> +obj-$(CONFIG_INTEL_SCU_PLATFORM) += scu/
> +obj-$(CONFIG_INTEL_SCU_WDT) += scu/
> +obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += scu/

One entry is enough.

...

> +obj-$(CONFIG_INTEL_SCU_IPC) += ipc.o
> +obj-$(CONFIG_INTEL_SCU_PCI) += pcidrv.o
> +obj-$(CONFIG_INTEL_SCU_WDT) += wdt.o

This is not an equivalent. Please, use the same approach as below.

> +intel_scu_pltdrv-y := pltdrv.o
> +obj-$(CONFIG_INTEL_SCU_PLATFORM) += intel_scu_pltdrv.o
> +intel_scu_ipcutil-y := ipcutil.o
> +obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += intel_scu_ipcutil.o

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-08-19 14:09    [W:0.146 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site