| Date | Fri, 13 Aug 2021 13:13:11 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH Part1 RFC v4 12/36] x86/sev: Add helper for validating pages in early enc attribute changes |
| |
On Wed, Jul 07, 2021 at 01:14:42PM -0500, Brijesh Singh wrote: > +void __init early_snp_set_memory_private(unsigned long vaddr, unsigned long paddr, > + unsigned int npages) > +{ > + if (!sev_feature_enabled(SEV_SNP)) > + return; > + > + /* Ask hypervisor to add the memory pages in RMP table as a 'private'. */
From a previous review:
Ask the hypervisor to mark the memory pages as private in the RMP table.
Are you missing my comments, do I have to write them more prominently or what is the problem?
DO I NEED TO WRITE IN CAPS ONLY MAYBE?
> +void __init early_snp_set_memory_shared(unsigned long vaddr, unsigned long paddr, > + unsigned int npages) > +{ > + if (!sev_feature_enabled(SEV_SNP)) > + return; > + > + /* > + * Invalidate the memory pages before they are marked shared in the > + * RMP table. > + */ > + pvalidate_pages(vaddr, npages, 0); > + > + /* Ask hypervisor to make the memory pages shared in the RMP table. */
From a previous review:
s/make/mark/
> + early_set_page_state(paddr, npages, SNP_PAGE_STATE_SHARED); > +} > + > +void __init snp_prep_memory(unsigned long paddr, unsigned int sz, int op)
that op should be:
enum psc_op { SNP_PAGE_STATE_SHARED, SNP_PAGE_STATE_PRIVATE, };
too.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|