Messages in this thread | | | Subject | Re: [PATCH] net: drop skbs in napi->rx_list when removing the napi context. | From | Phi Nguyen <> | Date | Fri, 13 Aug 2021 03:17:18 +0800 |
| |
On 8/12/2021 3:07 PM, Eric Dumazet wrote: > Also I object to this fix. > > If packets have been stored temporarily in GRO, they should be > released at some point, > normally at the end of a napi poll. > > By released, I mean that these packets should reach the upper stack, > instead of being dropped without > any notification. > > It seems a call to gro_normal_list() is missing somewhere. > > Can you find where ? > > Thanks ! > H Eric,
I think the location that should have a call to gro_normal_list() is __netif_napi_del(). Let say, if the driver call a function that lead to gro_normal_one(), and add a skb to the rx_list while the napi poll is not scheduled, and the driver remove the napi context before a napi poll could be triggered, then the added skb will be lost.
Actually, this was the first solution that I tried with syzbot (It passed the test too). Best regards, Phi
| |