Messages in this thread | | | Subject | Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly | From | John Hubbard <> | Date | Thu, 12 Aug 2021 11:19:01 -0700 |
| |
On 8/12/21 2:22 AM, Christoph Hellwig wrote: > On Wed, Aug 11, 2021 at 12:05:42AM -0700, John Hubbard wrote: >> - if (unlikely(!try_get_page(page))) >> + if (unlikely(try_get_compound_head(page, 1) == NULL)) > > Why not a simple ! instead of the == NULL?
I'll fix those up and post a v4.
> > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de> >
Thanks for the reviews!
thanks, -- John Hubbard NVIDIA
| |