lkml.org 
[lkml]   [2021]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly
From
Date
On 8/12/21 2:22 AM, Christoph Hellwig wrote:
> On Wed, Aug 11, 2021 at 12:05:42AM -0700, John Hubbard wrote:
>> - if (unlikely(!try_get_page(page)))
>> + if (unlikely(try_get_compound_head(page, 1) == NULL))
>
> Why not a simple ! instead of the == NULL?

I'll fix those up and post a v4.

>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>

Thanks for the reviews!


thanks,
--
John Hubbard
NVIDIA

\
 
 \ /
  Last update: 2021-08-12 20:20    [W:0.027 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site