lkml.org 
[lkml]   [2021]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case
On Thu, 12 Aug 2021 13:48:43 +0800
Hui Liu <hui.liu@mediatek.com> wrote:

> Add support IIO_CHAN_INFO_RAW case.
Why?

We almost never support both RAW and PROCESSED as userspace should be
fine to use either. There are a few reasons we've let drivers do
this but I would like know why it matters to you and it definitely
needs to be in the patch description.

>
> Signed-off-by: Hui Liu <hui.liu@mediatek.com>
> ---
> drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> index 79c1dd68b909..e995d43287b2 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible mt6765_compat = {
> .type = IIO_VOLTAGE, \
> .indexed = 1, \
> .channel = (idx), \
> - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> + BIT(IIO_CHAN_INFO_PROCESSED), \
> }
>
> static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = {
> @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev,
> struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev);
>
> switch (info) {
> + case IIO_CHAN_INFO_RAW:
> + *val = mt6577_auxadc_read(indio_dev, chan);
> + if (*val < 0) {
> + dev_notice(indio_dev->dev.parent,
> + "failed to sample data on channel[%d]\n",
> + chan->channel);
> + return *val;
> + }
> + if (adc_dev->dev_comp->sample_data_cali)
> + *val = mt_auxadc_get_cali_data(*val, true);
> +
> + return IIO_VAL_INT;
> +
> case IIO_CHAN_INFO_PROCESSED:
> *val = mt6577_auxadc_read(indio_dev, chan);
> if (*val < 0) {

\
 
 \ /
  Last update: 2021-08-12 20:08    [W:0.074 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site