Messages in this thread | | | Date | Thu, 29 Jul 2021 04:01:28 +0000 | From | yajun.deng@linux ... | Subject | Re: [PATCH] Revert "net: Get rid of consume_skb when tracing is off" |
| |
July 28, 2021 8:52 PM, "Herbert Xu" <herbert@gondor.apana.org.au> wrote:
> On Wed, Jul 28, 2021 at 11:56:05AM +0800, Yajun Deng wrote: > >> This reverts commit be769db2f95861cc8c7c8fedcc71a8c39b803b10. >> There is trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is >> also a trace function. >> >> Fixes: be769db2f958 (net: Get rid of consume_skb when tracing is off) >> Signed-off-by: Yajun Deng <yajun.deng@linux.dev> > > Please explain in more detail why your patch is needed. As it > stands I do not understand the reasoning. > if we don't define CONFIG_TRACEPOINTS, consume_skb() wolud called kfree_skb(), there have trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is also a trace function. So we can trace consume_skb() even if we don't define CONFIG_TRACEPOINTS. This patch "net: Get rid of consume_skb when tracing is off" does not seem to be effective.
> Thanks, > -- > Email: Herbert Xu <herbert@gondor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |