lkml.org 
[lkml]   [2021]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Revert "net: Get rid of consume_skb when tracing is off"
July 29, 2021 12:03 PM, "Herbert Xu" <herbert@gondor.apana.org.au> wrote:

> On Thu, Jul 29, 2021 at 04:01:28AM +0000, yajun.deng@linux.dev wrote:
>
>> if we don't define CONFIG_TRACEPOINTS, consume_skb() wolud called kfree_skb(), there have
>> trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is also a trace function. So we
>> can trace consume_skb() even if we don't define CONFIG_TRACEPOINTS.
>> This patch "net: Get rid of consume_skb when tracing is off" does not seem to be effective.
>
> The point of my patch was to get rid of consume_skb because its
> only purpose is to provide extra information for tracing. If you're
> not tracing then you don't need that extra information (and overhead).
>
Ok, I didn't understand it well.
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2021-07-29 06:11    [W:0.044 / U:1.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site