[lkml]   [2021]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 1/5] HID: magicmouse: register power supply
On Fri, 25 Jun 2021, José Expósito wrote:

> > > [...]
> > > v2: Add depends on USB_HID to Kconfig
> >
> > Hmm, why is this dependency needed in the first place, please? I think
> > trying to keep the drivers independent on transport drivers (especially in
> > cases like this, where more variants of physical transports actually
> > really do exist) is worth trying.
> Sorry, that's something I should have explained in the changelog.
> Intel's test bot reported compilation errors on the first version of the patch
> when USB support wasn't configured:
> I was kindly pointed to a similar error and its fix, but, maybe in this case this
> is not the right fix?
> Maybe there is a macro that I can use to wrap the USB related code in an #ifdef?

It can certainly be wrapped, but looking into the code now, it probably
wouldn't really bring more clarity. I will apply the series with adding
the USB_HID dependency for now.


Jiri Kosina

 \ /
  Last update: 2021-07-28 11:36    [W:0.090 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site