Messages in this thread | | | Date | Fri, 25 Jun 2021 19:08:34 +0200 | From | José Expósito <> | Subject | Re: [PATCH v2 1/5] HID: magicmouse: register power supply |
| |
Hi Jiri,
First of all, thank you for taking the time to review my patches.
On Thu, Jun 24, 2021 at 03:33:39PM +0200, Jiri Kosina wrote: > On Sat, 22 May 2021, José Expósito wrote: > > > [...] > > v2: Add depends on USB_HID to Kconfig > > Hmm, why is this dependency needed in the first place, please? I think > trying to keep the drivers independent on transport drivers (especially in > cases like this, where more variants of physical transports actually > really do exist) is worth trying.
Sorry, that's something I should have explained in the changelog.
Intel's test bot reported compilation errors on the first version of the patch when USB support wasn't configured: https://lore.kernel.org/patchwork/patch/1425313/
I was kindly pointed to a similar error and its fix, but, maybe in this case this is not the right fix? Maybe there is a macro that I can use to wrap the USB related code in an #ifdef?
Thanks, Jose
| |