Messages in this thread | | | From | Carlos Bilbao <> | Subject | Re: [PATCH v2] include: linux: Reorganize timekeeping and ktime headers | Date | Thu, 22 Jul 2021 07:54:22 -0400 |
| |
On Wednesday, July 21, 2021 5:09:50 PM EDT Thomas Gleixner wrote: > > I have no objections against this change per se, but I'm missing the > actual problem it is trying to solve. What's the fail it fixes or is it > just a general consolidation? The above is blury in that regard. >
Well, at first I just wanted to fix the header dependencies, since timekeeping.h is using ktime_to_ns(), a static function defined ktime.h, but it does not include the header. Then Arnd rightly pointed out this was an opportunity to perform a bit more housekeeping and consolidation, yes.
> > This patch also includes the header timekeeping.h wherever it is > > necessary for a successful compilation after the header code > > reorganization. > > Please do: > > git grep 'This patch' Documentation/process/ > > and follow the instructions there.
All right, I understand I should be following the imperative mood there.
> > Aside of that I assume that you only covered x86 in build testing which > is not cutting it as this is generic infrastructure affecting _all_ > architectures. > > Thanks, > > tglx
Thanks for the feedback Thomas, I will cross compile with the other archs to make sure we are not leaving anyone behind and send updated version (v3).
Carlos-
| |