Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2] include: linux: Reorganize timekeeping and ktime headers | Date | Wed, 21 Jul 2021 23:09:50 +0200 |
| |
Carlos,
On Mon, Jul 19 2021 at 11:19, Carlos Bilbao wrote: > Reorganize and separate the headers by making ktime.h take care of the > ktime_get() family of functions, and reserve timekeeping.h for the actual > timekeeping. This also helps to avoid implicit function errors and strengthens > the header dependencies, since timekeeping.h was using ktime_to_ns(), a static > function defined in a header it does no include, ktime.h.
I have no objections against this change per se, but I'm missing the actual problem it is trying to solve. What's the fail it fixes or is it just a general consolidation? The above is blury in that regard.
> This patch also includes the header timekeeping.h wherever it is > necessary for a successful compilation after the header code > reorganization.
Please do:
git grep 'This patch' Documentation/process/
and follow the instructions there.
Aside of that I assume that you only covered x86 in build testing which is not cutting it as this is generic infrastructure affecting _all_ architectures.
Thanks,
tglx
| |