lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hyperv: root partition faults writing to VP ASSIST MSR PAGE
On Tue, Jul 20, 2021 at 06:55:56PM +0530, Praveen Kumar wrote:
[...]
> >
> >> + if (hv_root_partition &&
> >> + ms_hyperv.features & HV_MSR_APIC_ACCESS_AVAILABLE) {
> >
> > Is HV_MSR_APIC_ACCESS_AVAILABLE a root only flag? Shouldn't non-root
> > kernel check this too?
>
> Yes, you are right. Will update this in v2. thanks.

Please split adding this check to its own patch.

Ideally one patch only does one thing.

Wei.

>
> >
> > Wei.
> >
>
> Regards,
>
> ~Praveen.

\
 
 \ /
  Last update: 2021-07-20 15:39    [W:0.894 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site