Messages in this thread | | | Date | Fri, 2 Jul 2021 15:52:52 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set |
| |
On Fri, Jul 02, 2021 at 02:23:48PM +0200, Matthias Schiffer wrote: > The driver was registering IRQ 0 when no IRQ was set. This leads to > warnings with newer kernels. > > Clear the resource flags, so no resource is registered at all in this > case. > > Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO") > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > --- > > v2: add Fixes line > > Andy recommended to use IORESOURCE_DISABLED instead, but this doesn't > have any effect for platform_get_irq(), so I'm resubmitting this patch > without functional changes. Grepping for '\.flags = 0;' shows other > drivers doing the same.
IORESOURCE_DISABLED seems to have an odd meaning. It seems to be about ACPI and the resource needs to be enabled before it can be used.
So .flags = 0 seems reasonable.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |