lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[allisonhenderson-xfs_work:delayed_attrs_v21_extended 54/62] fs/xfs/libxfs/xfs_trans_resv.c:854:1: warning: no previous prototype for 'xfs_calc_namespace_reservations'
tree:   https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v21_extended
head: 1a71ced599b41e7ee9f0ea02427b76c30f71f7dd
commit: 4801b661f577ce8fa4a27b26493a7b4c5bf327b4 [54/62] xfs: extent transaction reservations for parent attributes
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/allisonhenderson/xfs_work/commit/4801b661f577ce8fa4a27b26493a7b4c5bf327b4
git remote add allisonhenderson-xfs_work https://github.com/allisonhenderson/xfs_work.git
git fetch --no-tags allisonhenderson-xfs_work delayed_attrs_v21_extended
git checkout 4801b661f577ce8fa4a27b26493a7b4c5bf327b4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=s390

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/xfs/libxfs/xfs_trans_resv.c:854:1: warning: no previous prototype for 'xfs_calc_namespace_reservations' [-Wmissing-prototypes]
854 | xfs_calc_namespace_reservations(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/xfs_calc_namespace_reservations +854 fs/xfs/libxfs/xfs_trans_resv.c

834
835 /*
836 * Namespace reservations.
837 *
838 * These get tricky when parent pointers are enabled as we have attribute
839 * modifications occurring from within these transactions. Rather than confuse
840 * each of these reservation calculations with the conditional attribute
841 * reservations, add them here in a clear and concise manner. This assumes that
842 * the attribute reservations have already been calculated.
843 *
844 * Note that we only include the static attribute reservation here; the runtime
845 * reservation will have to be modified by the size of the attributes being
846 * added/removed/modified. See the comments on the attribute reservation
847 * calculations for more details.
848 *
849 * Note for rename: rename will vastly overestimate requirements. This will be
850 * addressed later when modifications are made to ensure parent attribute
851 * modifications can be done atomically with the rename operation.
852 */
853 void
> 854 xfs_calc_namespace_reservations(
855 struct xfs_mount *mp,
856 struct xfs_trans_resv *resp)
857 {
858 ASSERT(resp->tr_attrsetm.tr_logres > 0);
859
860 resp->tr_rename.tr_logres = xfs_calc_rename_reservation(mp);
861 resp->tr_rename.tr_logcount = XFS_RENAME_LOG_COUNT;
862 resp->tr_rename.tr_logflags |= XFS_TRANS_PERM_LOG_RES;
863
864 resp->tr_link.tr_logres = xfs_calc_link_reservation(mp);
865 resp->tr_link.tr_logcount = XFS_LINK_LOG_COUNT;
866 resp->tr_link.tr_logflags |= XFS_TRANS_PERM_LOG_RES;
867
868 resp->tr_remove.tr_logres = xfs_calc_remove_reservation(mp);
869 resp->tr_remove.tr_logcount = XFS_REMOVE_LOG_COUNT;
870 resp->tr_remove.tr_logflags |= XFS_TRANS_PERM_LOG_RES;
871
872 resp->tr_symlink.tr_logres = xfs_calc_symlink_reservation(mp);
873 resp->tr_symlink.tr_logcount = XFS_SYMLINK_LOG_COUNT;
874 resp->tr_symlink.tr_logflags |= XFS_TRANS_PERM_LOG_RES;
875
876 resp->tr_create.tr_logres = xfs_calc_icreate_reservation(mp);
877 resp->tr_create.tr_logcount = XFS_CREATE_LOG_COUNT;
878 resp->tr_create.tr_logflags |= XFS_TRANS_PERM_LOG_RES;
879
880 resp->tr_mkdir.tr_logres = xfs_calc_mkdir_reservation(mp);
881 resp->tr_mkdir.tr_logcount = XFS_MKDIR_LOG_COUNT;
882 resp->tr_mkdir.tr_logflags |= XFS_TRANS_PERM_LOG_RES;
883
884 xfs_calc_parent_ptr_reservations(mp);
885 }
886

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-07-19 06:39    [W:0.064 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site