Messages in this thread Patch in this message | | | From | Frank Wunderlich <> | Subject | [PATCH] iommu: check if group is NULL before remove device | Date | Thu, 15 Jul 2021 09:11:50 +0200 |
| |
From: Frank Wunderlich <frank-w@public-files.de>
if probe is failing, iommu_group may be not initialized, so freeing it will result in NULL pointer access
Fixes: d72e31c93746 ("iommu: IOMMU Groups") Signed-off-by: Frank Wunderlich <frank-w@public-files.de> --- drivers/iommu/iommu.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 5419c4b9f27a..63f0af10c403 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -924,6 +924,9 @@ void iommu_group_remove_device(struct device *dev) struct iommu_group *group = dev->iommu_group; struct group_device *tmp_device, *device = NULL; + if (!group) + return; + dev_info(dev, "Removing from iommu group %d\n", group->id); /* Pre-notify listeners that a device is being removed. */ -- 2.25.1
| |