Messages in this thread | | | From | "Williams, Dan J" <> | Subject | Re: [PATCH 01/14] x86/cpu: Move intel-family to arch-independent headers | Date | Wed, 14 Jul 2021 16:54:47 +0000 |
| |
On Tue, 2021-07-13 at 00:04 +0200, Iwona Winiarska wrote: > Baseboard management controllers (BMC) often run Linux but are usually > implemented with non-X86 processors. They can use PECI to access package > config space (PCS) registers on the host CPU and since some information, > e.g. figuring out the core count, can be obtained using different > registers on different CPU generations, they need to decode the family > and model. > > Move the data from arch/x86/include/asm/intel-family.h into a new file > include/linux/x86/intel-family.h so that it can be used by other > architectures.
At least it would make the diffstat smaller to allow for rename detection when the old file is deleted in the same patch:
MAINTAINERS | 1 + {arch/x86/include/asm => include/linux/x86}/intel-family.h | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-)
...one thing people have done in the past is include a conversion script in the changelog that produced the diff. That way if a maintainer wants to be sure to catch any new usage of the header at the old location they just run the script.
I am not aware of x86 maintainer preference here. Either way you decide to go you can add:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
| |