Messages in this thread Patch in this message | | | From | Yang Li <> | Subject | [PATCH] thermal/drivers/tsens: fix usage of unititialized value | Date | Tue, 8 Jun 2021 17:41:39 +0800 |
| |
When "tsens_version(priv) > VER_0_1" is false, "regmap_field_read(priv->rf[VER_MINOR], &ver_minor)" can't execute. So, ver_minor has no initialization and assignment before it is used, and we initialize it to 0.
Clean up smatch warning: drivers/thermal/qcom/tsens.c:896 init_common() error: uninitialized symbol 'ver_minor'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/thermal/qcom/tsens.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 4c7ebd1..a36c43d 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -743,8 +743,8 @@ int __init init_common(struct tsens_priv *priv) { void __iomem *tm_base, *srot_base; struct device *dev = priv->dev; - u32 ver_minor; struct resource *res; + u32 ver_minor = 0; u32 enabled; int ret, i, j; struct platform_device *op = of_find_device_by_node(priv->dev->of_node); -- 1.8.3.1
| |