lkml.org 
[lkml]   [2021]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 03/10] raid-md: reduce stack footprint dealing with block device names
From
Date
Hi,

Maybe replace "raid-md" with "md/raid" or just "md".

On 6/23/21 1:44 AM, Anton Suvorov wrote:
> Stack usage reduced (measured with allyesconfig):
>
> ./drivers/md/md-linear.c linear_make_request 248 112 -136
> ./drivers/md/md-multipath.c multipath_end_request 232 96 -136
> ./drivers/md/md-multipath.c multipath_error 208 72 -136
> ./drivers/md/md-multipath.c multipathd 248 112 -136
> ./drivers/md/md-multipath.c print_multipath_conf 208 64 -144
> ./drivers/md/md.c autorun_devices 312 184 -128
> ./drivers/md/md.c export_rdev 168 32 -136
> ./drivers/md/md.c md_add_new_disk 280 80 -200
> ./drivers/md/md.c md_import_device 200 56 -144
> ./drivers/md/md.c md_integrity_add_rdev 192 56 -136
> ./drivers/md/md.c md_ioctl 560 496 -64
> ./drivers/md/md.c md_reload_sb 224 88 -136
> ./drivers/md/md.c md_run 408 288 -120
> ./drivers/md/md.c md_seq_show 232 96 -136
> ./drivers/md/md.c md_update_sb 304 168 -136
> ./drivers/md/md.c read_disk_sb 184 48 -136
> ./drivers/md/md.c super_1_load 392 192 -200
> ./drivers/md/md.c super_90_load 304 112 -192
> ./drivers/md/md.c unbind_rdev_from_array 200 64 -136
> ./drivers/md/raid0.c create_strip_zones 400 200 -200
> ./drivers/md/raid0.c dump_zones 536 464 -72
> ./drivers/md/raid1.c fix_read_error 352 288 -64
> ./drivers/md/raid1.c print_conf 224 80 -144
> ./drivers/md/raid1.c raid1_end_read_request 216 80 -136
> ./drivers/md/raid1.c raid1_error 216 96 -120
> ./drivers/md/raid1.c sync_request_write 344 208 -136
> ./drivers/md/raid10.c fix_read_error 392 320 -72
> ./drivers/md/raid10.c print_conf 216 72 -144
> ./drivers/md/raid10.c raid10_end_read_request 216 80 -136
> ./drivers/md/raid10.c raid10_error 216 80 -136
> ./drivers/md/raid5-cache.c r5l_init_log 224 88 -136
> ./drivers/md/raid5-ppl.c ppl_do_flush 256 136 -120
> ./drivers/md/raid5-ppl.c ppl_flush_endio 192 56 -136
> ./drivers/md/raid5-ppl.c ppl_modify_log 192 56 -136
> ./drivers/md/raid5-ppl.c ppl_recover_entry 1296 1232 -64
> ./drivers/md/raid5-ppl.c ppl_submit_iounit_bio 192 56 -136
> ./drivers/md/raid5-ppl.c ppl_validate_rdev 184 48 -136
> ./drivers/md/raid5.c print_raid5_conf 208 64 -144
> ./drivers/md/raid5.c raid5_end_read_request 272 128 -144
> ./drivers/md/raid5.c raid5_error 216 80 -136
> ./drivers/md/raid5.c setup_conf 360 296 -64
>
> Signed-off-by: Anton Suvorov <warwish@yandex-team.ru>
> ---
> drivers/md/md-linear.c | 5 +-
> drivers/md/md-multipath.c | 24 +++----
> drivers/md/md.c | 135 ++++++++++++++------------------------
> drivers/md/raid0.c | 28 ++++----
> drivers/md/raid1.c | 25 +++----
> drivers/md/raid10.c | 65 ++++++++----------
> drivers/md/raid5-cache.c | 5 +-
> drivers/md/raid5-ppl.c | 40 +++++------
> drivers/md/raid5.c | 39 +++++------
> 9 files changed, 144 insertions(+), 222 deletions(-)

Also a nice cleanup!  Acked-by: Guoqing Jiang <jiangguoqing@kylinos.cn>

Thanks,
Guoqing


\
 
 \ /
  Last update: 2021-06-23 10:27    [W:0.097 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site