lkml.org 
[lkml]   [2021]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 01/10] drbd: reduce stack footprint in drbd_report_io_error()
    Date
    Stack usage reduced (measured with allyesconfig):

    ./drivers/block/drbd/drbd_req.c drbd_report_io_error 200 72 -128

    Signed-off-by: Anton Suvorov <warwish@yandex-team.ru>
    ---
    drivers/block/drbd/drbd_req.c | 12 +++++-------
    1 file changed, 5 insertions(+), 7 deletions(-)

    diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
    index 13beb98a7c5a..bd7265edf614 100644
    --- a/drivers/block/drbd/drbd_req.c
    +++ b/drivers/block/drbd/drbd_req.c
    @@ -510,16 +510,14 @@ static void mod_rq_state(struct drbd_request *req, struct bio_and_error *m,

    static void drbd_report_io_error(struct drbd_device *device, struct drbd_request *req)
    {
    - char b[BDEVNAME_SIZE];
    -
    if (!__ratelimit(&drbd_ratelimit_state))
    return;

    - drbd_warn(device, "local %s IO error sector %llu+%u on %s\n",
    - (req->rq_state & RQ_WRITE) ? "WRITE" : "READ",
    - (unsigned long long)req->i.sector,
    - req->i.size >> 9,
    - bdevname(device->ldev->backing_bdev, b));
    + drbd_warn(device, "local %s IO error sector %llu+%u on %pg\n",
    + (req->rq_state & RQ_WRITE) ? "WRITE" : "READ",
    + (unsigned long long)req->i.sector,
    + req->i.size >> 9,
    + device->ldev->backing_bdev);
    }

    /* Helper for HANDED_OVER_TO_NETWORK.
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-06-22 19:45    [W:4.844 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site