Messages in this thread | | | From | Justin He <> | Subject | RE: [PATCH v5 1/4] fs: introduce helper d_path_unsafe() | Date | Thu, 24 Jun 2021 02:35:02 +0000 |
| |
Hi Andy
> -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Wednesday, June 23, 2021 5:07 PM > To: Justin He <Justin.He@arm.com> > Cc: Petr Mladek <pmladek@suse.com>; Steven Rostedt <rostedt@goodmis.org>; > Sergey Senozhatsky <senozhatsky@chromium.org>; Rasmus Villemoes > <linux@rasmusvillemoes.dk>; Jonathan Corbet <corbet@lwn.net>; Alexander > Viro <viro@zeniv.linux.org.uk>; Linus Torvalds <torvalds@linux- > foundation.org>; Peter Zijlstra (Intel) <peterz@infradead.org>; Eric > Biggers <ebiggers@google.com>; Ahmed S. Darwish <a.darwish@linutronix.de>; > linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > fsdevel@vger.kernel.org; Matthew Wilcox <willy@infradead.org>; Christoph > Hellwig <hch@infradead.org>; nd <nd@arm.com> > Subject: Re: [PATCH v5 1/4] fs: introduce helper d_path_unsafe() > > On Wed, Jun 23, 2021 at 02:02:45AM +0000, Justin He wrote: > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > Sent: Tuesday, June 22, 2021 10:37 PM > > > On Tue, Jun 22, 2021 at 10:06:31PM +0800, Jia He wrote: > > ... > > > > > * prepend_name - prepend a pathname in front of current buffer > pointer > > > > - * @buffer: buffer pointer > > > > - * @buflen: allocated length of the buffer > > > > + * @p: prepend buffer which contains buffer pointer and allocated > length > > > > > > > * @name: name string and length qstr structure > > > > > > Indentation issue btw, can be fixed in the same patch. > > > > Okay > > > > > > > * > > > > * With RCU path tracing, it may race with d_move(). Use READ_ONCE() > to > > > > > > Shouldn't this be a separate change with corresponding Fixes tag? > > > > Sorry, I don't quite understand here. > > What do you want to fix? > > Kernel doc. The Fixes tag should correspond to the changes that missed the > update of kernel doc. Ah, I got your point. Actually, this is originated from an unmerged patch [1]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/commit/?h=work.d_path&id=ad08ae586586ea9e2c0228a3d5a083500ea54202
I will ping Al Viro to fix this
-- Cheers, Justin (Jia He)
| |