Messages in this thread | | | Date | Wed, 23 Jun 2021 12:07:11 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 1/4] fs: introduce helper d_path_unsafe() |
| |
On Wed, Jun 23, 2021 at 02:02:45AM +0000, Justin He wrote: > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Sent: Tuesday, June 22, 2021 10:37 PM > > On Tue, Jun 22, 2021 at 10:06:31PM +0800, Jia He wrote:
...
> > > * prepend_name - prepend a pathname in front of current buffer pointer > > > - * @buffer: buffer pointer > > > - * @buflen: allocated length of the buffer > > > + * @p: prepend buffer which contains buffer pointer and allocated length > > > > > * @name: name string and length qstr structure > > > > Indentation issue btw, can be fixed in the same patch. > > Okay > > > > > * > > > * With RCU path tracing, it may race with d_move(). Use READ_ONCE() to > > > > Shouldn't this be a separate change with corresponding Fixes tag? > > Sorry, I don't quite understand here. > What do you want to fix?
Kernel doc. The Fixes tag should correspond to the changes that missed the update of kernel doc.
-- With Best Regards, Andy Shevchenko
| |