lkml.org 
[lkml]   [2021]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/54] KVM: x86/mmu: Bug fixes and summer cleaning
On Wed, Jun 23, 2021, Paolo Bonzini wrote:
> On 23/06/21 23:06, Sean Christopherson wrote:
> > >
> > > This is good stuff, I made a few comments but almost all of them (all except
> > > the last comment on patch 9, "Unconditionally zap unsync SPs") are cosmetic
> > > and I can resolve them myself.
> > The 0-day bot also reported some warnings. vcpu_to_role_regs() needs to be
> > static, the helpers are added without a user. I liked the idea of adding the
> > helpers in one patch, but I can't really defend adding them without a user. :-/
>
> Yep, I noticed them too.
>
> We can just mark them static inline, which is a good idea anyway and enough

But they already are static inline :-(

> to shut up the compiler (clang might behave different in this respect for .h
> and .c files, but again it's just a warning and not a bisection breakage).

I was worried about the CONFIG_KVM_WERROR=y case.

\
 
 \ /
  Last update: 2021-06-24 00:08    [W:1.753 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site