lkml.org 
[lkml]   [2021]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 00/54] KVM: x86/mmu: Bug fixes and summer cleaning
From
Date
On 23/06/21 23:06, Sean Christopherson wrote:
>>
>> This is good stuff, I made a few comments but almost all of them (all except
>> the last comment on patch 9, "Unconditionally zap unsync SPs") are cosmetic
>> and I can resolve them myself.
> The 0-day bot also reported some warnings. vcpu_to_role_regs() needs to be
> static, the helpers are added without a user. I liked the idea of adding the
> helpers in one patch, but I can't really defend adding them without a user. :-/

Yep, I noticed them too.

We can just mark them static inline, which is a good idea anyway and
enough to shut up the compiler (clang might behave different in this
respect for .h and .c files, but again it's just a warning and not a
bisection breakage).

Paolo

> arch/x86/kvm/mmu/mmu.c:209:26: warning: no previous prototype for function 'vcpu_to_role_regs' [-Wmissing-prototypes]
> struct kvm_mmu_role_regs vcpu_to_role_regs(struct kvm_vcpu *vcpu)
> ^
> arch/x86/kvm/mmu/mmu.c:209:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> struct kvm_mmu_role_regs vcpu_to_role_regs(struct kvm_vcpu *vcpu)
> ^
> static
> arch/x86/kvm/mmu/mmu.c:199:1: warning: unused function '____is_cr0_wp' [-Wunused-function]
> BUILD_MMU_ROLE_REGS_ACCESSOR(cr0, wp, X86_CR0_WP);
>

\
 
 \ /
  Last update: 2021-06-23 23:33    [W:0.084 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site