Messages in this thread Patch in this message | | | From | Zhen Lei <> | Subject | [PATCH 1/1] pstore: remove unnecessary oom message | Date | Thu, 17 Jun 2021 17:10:54 +0800 |
| |
Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message
Remove it can help us save a bit of memory.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- fs/pstore/platform.c | 4 +--- fs/pstore/ram_core.c | 15 ++++----------- 2 files changed, 5 insertions(+), 14 deletions(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index b9614db48b1d..752c2338af6c 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -752,10 +752,8 @@ void pstore_get_backend_records(struct pstore_info *psi, int rc; record = kzalloc(sizeof(*record), GFP_KERNEL); - if (!record) { - pr_err("out of memory creating record\n"); + if (!record) break; - } pstore_record_init(record, psi); record->size = psi->read(record); diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index fe5305028c6e..7da890505025 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c @@ -301,10 +301,8 @@ void persistent_ram_save_old(struct persistent_ram_zone *prz) if (!prz->old_log) { persistent_ram_ecc_old(prz); prz->old_log = kmalloc(size, GFP_KERNEL); - } - if (!prz->old_log) { - pr_err("failed to allocate buffer\n"); - return; + if (!prz->old_log) + return; } prz->old_log_size = size; @@ -429,11 +427,8 @@ static void *persistent_ram_vmap(phys_addr_t start, size_t size, } pages = kmalloc_array(page_count, sizeof(struct page *), GFP_KERNEL); - if (!pages) { - pr_err("%s: Failed to allocate array for %u pages\n", - __func__, page_count); + if (!pages) return NULL; - } for (i = 0; i < page_count; i++) { phys_addr_t addr = page_start + i * PAGE_SIZE; @@ -578,10 +573,8 @@ struct persistent_ram_zone *persistent_ram_new(phys_addr_t start, size_t size, int ret = -ENOMEM; prz = kzalloc(sizeof(struct persistent_ram_zone), GFP_KERNEL); - if (!prz) { - pr_err("failed to allocate persistent ram zone\n"); + if (!prz) goto err; - } /* Initialize general buffer state. */ raw_spin_lock_init(&prz->buffer_lock); -- 2.25.1
| |