Messages in this thread | | | From | Marcin Wojtas <> | Subject | [net-next: PATCH v2 0/7] ACPI MDIO support for Marvell controllers | Date | Wed, 16 Jun 2021 21:07:52 +0200 |
| |
Hi,
The second version of the patchset addresses all comments received during v1 review and introduces a couple of new patches that were requested.
fwnode_mdiobus_register() helper routine was added and it is used now by 2 drivers (xgmac_mdio and mvmdio). In the latter a clock handling was significantly simplified by a switch to a devm_clk_bulk_get_optional().
Last but not least two additional MAC configuration modes ACPI desctiption were documented ("managed" and "fixed-link") - they can be processed by the existing fwnode_ phylink helpers and comply with the standard _DSD properties and hierarchical data extension. ACPI Maintainers are therefore added to reviewers' list.
More details can be found in the patches and their commit messages.
As before, the feature was verified with ACPI on MacchiatoBin, CN913x-DB and Armada 8040 DB (fixed-link handling). Moreover regression tests were performed (old firmware with updated kernel, new firmware with old kernel and the operation with DT).
The firmware ACPI description is exposed in the public github branch: https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/acpi-mdio-r20210613 There is also MacchiatoBin firmware binary available for testing: https://drive.google.com/file/d/1eigP_aeM4wYQpEaLAlQzs3IN_w1-kQr0
I'm looking forward to the comments or remarks.
Best regards, Marcin
Changelog: v1->v2 * 1/7 - new patch * 2/7 - new patch * 3/7 - new patch * 4/7 - new patch * 5/7 - remove unnecessary `if (has_acpi_companion())` and rebase onto the new clock handling * 6/7 - remove deprecated comment * 7/7 - no changes
Marcin Wojtas (7): Documentation: ACPI: DSD: describe additional MAC configuration net: mdiobus: Introduce fwnode_mdbiobus_register() net/fsl: switch to fwnode_mdiobus_register net: mvmdio: simplify clock handling net: mvmdio: add ACPI support net: mvpp2: enable using phylink with ACPI net: mvpp2: remove unused 'has_phy' field
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 3 - include/linux/fwnode_mdio.h | 12 ++++ drivers/net/ethernet/freescale/xgmac_mdio.c | 11 +-- drivers/net/ethernet/marvell/mvmdio.c | 75 ++++++++------------ drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 23 ++++-- drivers/net/mdio/fwnode_mdio.c | 22 ++++++ Documentation/firmware-guide/acpi/dsd/phy.rst | 55 ++++++++++++++ 7 files changed, 138 insertions(+), 63 deletions(-)
-- 2.29.0
| |