lkml.org 
[lkml]   [2021]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: i2c: Move i2c-omap.txt to YAML format
Hi,

* Vignesh Raghavendra <vigneshr@ti.com> [210505 06:55]:
> Convert i2c-omap.txt to YAML schema for better checks and documentation.

Nice to see this happening, few minor comments below on handling the
legacy devices.

> +properties:
> + compatible:
> + oneOf:
> + - const: ti,omap2420-i2c
> + - const: ti,omap2430-i2c
> + - const: ti,omap3-i2c
> + - const: ti,omap4-i2c
> + - items:
> + - enum:
> + - ti,am4372-i2c
> + - ti,am64-i2c
> + - ti,am654-i2c
> + - ti,j721e-i2c
> + - const: ti,omap4-i2c

I wonder if we should just add all the compatible options to the
driver, and have all these as oneOf?

> + ti,hwmods:
> + description:
> + Must be "i2c<n>", n being the instance number (1-based)
> + $ref: /schemas/types.yaml#/definitions/string
> + items:
> + - pattern: "^i2c([1-9])$"

The ti,hwmods is a legacy property that is only needed for omap2/3 and
ti81xx. At least the description should mention that to avoid folks
adding it accidentally.

Regards,

Tony

\
 
 \ /
  Last update: 2021-05-05 09:19    [W:0.032 / U:1.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site