lkml.org 
[lkml]   [2021]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dt-bindings: i2c: Move i2c-omap.txt to YAML format
From
Date
Hi,

On 5/5/21 12:48 PM, Tony Lindgren wrote:
> Hi,
>
> * Vignesh Raghavendra <vigneshr@ti.com> [210505 06:55]:
>> Convert i2c-omap.txt to YAML schema for better checks and documentation.
>
> Nice to see this happening, few minor comments below on handling the
> legacy devices.
>
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: ti,omap2420-i2c
>> + - const: ti,omap2430-i2c
>> + - const: ti,omap3-i2c
>> + - const: ti,omap4-i2c
>> + - items:
>> + - enum:
>> + - ti,am4372-i2c
>> + - ti,am64-i2c
>> + - ti,am654-i2c
>> + - ti,j721e-i2c
>> + - const: ti,omap4-i2c
>
> I wonder if we should just add all the compatible options to the
> driver, and have all these as oneOf?
>

This would also need updates to dts files too. Also not a fan of adding
all compatibles to driver code unless required.

>> + ti,hwmods:
>> + description:
>> + Must be "i2c<n>", n being the instance number (1-based)
>> + $ref: /schemas/types.yaml#/definitions/string
>> + items:
>> + - pattern: "^i2c([1-9])$"
>
> The ti,hwmods is a legacy property that is only needed for omap2/3 and
> ti81xx. At least the description should mention that to avoid folks
> adding it accidentally.
>

Sure, will do in v2. Thanks for the review!


Regards
Vignesh

\
 
 \ /
  Last update: 2021-05-05 20:07    [W:0.038 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site