Messages in this thread | | | Date | Wed, 5 May 2021 12:43:38 +0200 | From | David Sterba <> | Subject | Re: [PATCH 22/35] tty: make tty_operations::write_room return uint |
| |
On Wed, May 05, 2021 at 11:19:15AM +0200, Jiri Slaby wrote: > Line disciplines expect a positive value or zero returned from > tty->ops->write_room (invoked by tty_write_room). So make this > assumption explicit by using unsigned int as a return value. Both of > tty->ops->write_room and tty_write_room. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> > Cc: Matt Turner <mattst88@gmail.com> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> > Cc: Helge Deller <deller@gmx.de> > Cc: Jeff Dike <jdike@addtoit.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> > Cc: Chris Zankel <chris@zankel.net> > Cc: Max Filippov <jcmvbkbc@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com> > Cc: Jens Taprogge <jens.taprogge@taprogge.org> > Cc: Karsten Keil <isdn@linux-pingi.de> > Cc: Scott Branden <scott.branden@broadcom.com> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Heiko Carstens <hca@linux.ibm.com> > Cc: Vasily Gorbik <gor@linux.ibm.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: David Lin <dtwlin@gmail.com> > Cc: Johan Hovold <johan@kernel.org> > Cc: Alex Elder <elder@kernel.org> > Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: David Sterba <dsterba@suse.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Oliver Neukum <oneukum@suse.com> > Cc: Felipe Balbi <balbi@kernel.org> > Cc: Mathias Nyman <mathias.nyman@intel.com> > Cc: Marcel Holtmann <marcel@holtmann.org> > Cc: Johan Hedberg <johan.hedberg@gmail.com> > Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > --- > drivers/tty/ipwireless/tty.c | 2 +-
Acked-by: David Sterba <dsterba@suse.com>
| |