lkml.org 
[lkml]   [2021]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/35] tty: remove broken r3964 line discipline
On Wed, May 05, 2021 at 11:18:54AM +0200, Jiri Slaby wrote:
> Noone stepped up in the past two years since it was marked as BROKEN by
> commit c7084edc3f6d (tty: mark Siemens R3964 line discipline as BROKEN).
> Remove the line discipline for good.
>
> Three remarks:
> * we remove also the uapi header (as noone is able to use that interface
> anyway)
> * we do *not* remove the N_R3964 constant definition from tty.h, so it
> remains reserved.
> * in_interrupt() check is now removed from vt's con_put_char. Noone else
> calls tty_operations::put_char from interrupt context.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
> arch/powerpc/configs/ppc6xx_defconfig | 1 -
> drivers/char/Kconfig | 13 -
> drivers/tty/Makefile | 1 -
> drivers/tty/n_r3964.c | 1283 -------------------------
> drivers/tty/vt/vt.c | 2 -
> include/linux/n_r3964.h | 175 ----
> include/uapi/linux/n_r3964.h | 99 --
> 7 files changed, 1574 deletions(-)
> delete mode 100644 drivers/tty/n_r3964.c
> delete mode 100644 include/linux/n_r3964.h
> delete mode 100644 include/uapi/linux/n_r3964.h

Oh yes, thank you! I guess no one really cares about this anymore,
thanks for removing it.

greg k-h

\
 
 \ /
  Last update: 2021-05-05 11:26    [W:0.185 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site