Messages in this thread Patch in this message | | | From | Guenter Roeck <> | Subject | [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI | Date | Tue, 4 May 2021 10:40:19 -0700 |
| |
With CONFIG_ACPI=n and -Werror, 0-day reports:
drivers/iio/chemical/bme680_i2c.c:46:36: error: 'bme680_acpi_match' defined but not used
Reported-by: kernel test robot <lkp@intel.com> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- Given the other patch, question of course is if this ACPI ID is real. A Google search suggests that this might not be the case. Should we remove it as well ? STK8312 has the same problem.
Jonathan, I think this needs your input before I send more patches.
drivers/iio/chemical/bme680_i2c.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/iio/chemical/bme680_i2c.c b/drivers/iio/chemical/bme680_i2c.c index 29c0dfa4702b..b5e75f145c19 100644 --- a/drivers/iio/chemical/bme680_i2c.c +++ b/drivers/iio/chemical/bme680_i2c.c @@ -42,11 +42,13 @@ static const struct i2c_device_id bme680_i2c_id[] = { }; MODULE_DEVICE_TABLE(i2c, bme680_i2c_id); +#ifdef CONFIG_ACPI static const struct acpi_device_id bme680_acpi_match[] = { {"BME0680", 0}, {}, }; MODULE_DEVICE_TABLE(acpi, bme680_acpi_match); +#endif static const struct of_device_id bme680_of_i2c_match[] = { { .compatible = "bosch,bme680", }, -- 2.25.1
| |