lkml.org 
[lkml]   [2021]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/3] media: fix zero-length USB control requests
Date
The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.

Control transfers without a data stage are treated as OUT requests by
the USB stack and should be using usb_sndctrlpipe(). Failing to do so
will now trigger a warning.

This series fixes the three media drivers that got this wrong.

Johan

Changes in v2
- keep the rtl28xxu zero-length read request which is needed for
proper type detection (Eero)


Johan Hovold (3):
media: gspca/gl860: fix zero-length control requests
media: gspca/sunplus: fix zero-length control requests
media: rtl28xxu: fix zero-length control request

drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 11 ++++++++++-
drivers/media/usb/gspca/gl860/gl860.c | 4 ++--
drivers/media/usb/gspca/sunplus.c | 8 ++++++--
3 files changed, 18 insertions(+), 5 deletions(-)

--
2.31.1

\
 
 \ /
  Last update: 2021-05-31 11:47    [W:0.036 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site