Messages in this thread | | | Date | Mon, 3 May 2021 18:38:00 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v3 1/4] staging: fbtft: Rectify GPIO handling |
| |
On Wed, Apr 28, 2021 at 04:04:12PM +0300, Andy Shevchenko wrote: > The infamous commit c440eee1a7a1 ("Staging: staging: fbtft: Switch to > the GPIO descriptor interface") broke GPIO handling completely. > It has already four commits to rectify and it seems not enough. > In order to fix the mess here we: > > 1) Set default to "inactive" for all requested pins > > 2) Fix CS#, RD#, and WR# pins polarity since it's active low > and GPIO descriptor interface takes it into consideration > from the Device Tree or ACPI > > 3) Consolidate chip activation (CS# assertion) under default > ->reset() callback > > To summarize the expectations about polarity for GPIOs: > > RD# Low > WR# Low > CS# Low > RESET# Low > DC or RS High > RW High > Data 0 .. 15 High > > See also Adafruit learning course [1] for the example of the schematics. > > While at it, drop unneeded NULL checks, since GPIO API is tolerant to that. > > [1]: https://learn.adafruit.com/adafruit-2-8-and-3-2-color-tft-touchscreen-breakout-v2/downloads > > Fixes: 92e3e884887c ("Staging: staging: fbtft: Fix GPIO handling") > Fixes: b918d1c27066 ("Staging: staging: fbtft: Fix reset assertion when using gpio descriptor") > Fixes: dbc4f989c878 ("Staging: staging: fbtft: Fix probing of gpio descriptor") > Fixes: c440eee1a7a1 ("Staging: staging: fbtft: Switch to the gpio descriptor interface")
I get the following error when trying to apply this:
Fixes tag: Fixes: 92e3e884887c ("Staging: staging: fbtft: Fix GPIO handling") Has these problem(s): - Subject does not match target commit subject Just use git log -1 --format='Fixes: %h ("%s")' Fixes tag: Fixes: b918d1c27066 ("Staging: staging: fbtft: Fix reset assertion when using gpio descriptor") Has these problem(s): - Subject does not match target commit subject Just use git log -1 --format='Fixes: %h ("%s")' Fixes tag: Fixes: dbc4f989c878 ("Staging: staging: fbtft: Fix probing of gpio descriptor") Has these problem(s): - Subject does not match target commit subject Just use git log -1 --format='Fixes: %h ("%s")' Fixes tag: Fixes: c440eee1a7a1 ("Staging: staging: fbtft: Switch to the gpio descriptor interface") Has these problem(s): - Subject does not match target commit subject Just use git log -1 --format='Fixes: %h ("%s")'
Please fix up for your next version of this series.
thanks,
greg k-h
| |