lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/4] staging: fbtft: Don't spam logs when probe is deferred
On Thu, Apr 29, 2021 at 05:42:44PM +0300, Dan Carpenter wrote:
> On Wed, Apr 28, 2021 at 04:04:14PM +0300, Andy Shevchenko wrote:

> > + if (IS_ERR(*gpiop))
> > + dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s GPIO\n", name);
>
> This should be a return statement:
>
> return dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s GPIO\n", name);

Thanks!

Funny that I have trapped to this and my patch that adds __must_check to avoid
exactly this situations had been reverted :-(


--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-04-29 18:58    [W:0.078 / U:1.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site