Messages in this thread Patch in this message |  | | From | Jim Cromie <> | Subject | [RFC PATCH v6 16/34] dyndbg: ddebug_add_module avoid adding empty modules | Date | Sat, 29 May 2021 14:00:11 -0600 |
| |
Don't create ddebug_table's for modules with 0 callsites. This saves memory, and avoids creating ddebug_tables with questionable contents, which would then be iterated over for 'cat control'.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- lib/dynamic_debug.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 7a15216e6bef..db7563a88d8a 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1033,6 +1033,12 @@ int ddebug_add_module(struct _ddebug *tab, struct _ddebug_site *sites, { struct ddebug_table *dt; + v3pr_info("add-module: %s.%d sites\n", modname, numdbgs); + if (!numdbgs) { + v3pr_info(" skip %s\n", modname); + return 0; + } + dt = kzalloc(sizeof(*dt), GFP_KERNEL); if (dt == NULL) { pr_err("error adding module: %s\n", modname); -- 2.31.1
|  |