Messages in this thread | | | Subject | Re: [PATCH 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches | From | Javier Martinez Canillas <> | Date | Fri, 28 May 2021 10:03:04 +0200 |
| |
Hello Thomas,
On 5/22/21 7:14 AM, Thomas Zimmermann wrote:
[snip]
>> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -127,6 +127,7 @@ config ARM >> select PERF_USE_VMALLOC >> select RTC_LIB >> select SET_FS >> + select SYSFB > > Don't select this as part of the architecture. Rather make an option for > SYSFB that depends in the architectures that supports it. >
Thanks a lot for the suggestion! I did this by making SYSFB's Kconfig option to be default y and depends on the supported architectures as you mentioned.
This not only is a cleaner approach but also will allow to not touch all the architectures platform code.
I'll wait for a few more days in case someone else has feedback and post a v2.
> Best regards > Thomas > >
Best regards, -- Javier Martinez Canillas Software Engineer New Platform Technologies Enablement team RHEL Engineering
| |